[VCL-337] Windows.pm delete_files_by_pattern may delete unintended files if an environment variable isn't defined

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.2
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 27/May/10 13:30
• Updated: 13/Jul/10 17:27
• Resolved: 13/Jul/10 17:27

Description

Windows.pm's delete_files_by_pattern() subroutine can delete unintended files if an environment variable is passed to it as the base directory argument and the environment variable isn't defined.

Example:
delete_files_by_pattern('$TEMP', '.')

A trailing '/' is always added to the base directory path because find is called and it will fail if a wildcard pattern is used and the base directory doesn't contain a trailing slash. If $TEMP isn't defined on the computer, the subroutine will attempt to delete . from /.