[VCL-300] shib users always have email notices turned off

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1
• Fix Version/s: 2.2
• Component/s: web gui (frontend)
• Assignee: Josh Thompson
• Reporter: Sean Dilda
• Created: 25/Jan/10 22:38
• Updated: 08/Apr/10 14:10
• Resolved: 08/Apr/10 14:10

Description

The login code for shib users always forces their email notices value to be set to 0, regardless of what the user selects. VCL should not be arbitrarily overriding a user's preferences. Here's a fix:

— web/.ht-inc/authmethods/shibauth.php (revision 903001)
+++ web/.ht-inc/authmethods/shibauth.php (working copy)
@@ -90,8 +90,7 @@
$email = mysql_escape_string($user['email']);
$query .= "email = '$email', ";
}

• $query .= "emailnotices = 0, "
• . "lastupdated = NOW() "
  + $query .= "lastupdated = NOW() "
  . "WHERE uid = {$user['id']}";
  doQuery($query, 101, 'vcl', 1);
  return $user;