[VCL-183] DataStructure.pm contains duplicate subroutines: get_computer_private_ip and get_computer_private_ip_address

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0
• Fix Version/s: 2.1
• Component/s: vcld (backend)
• Assignee: Andrew Kurth
• Reporter: Andrew Kurth
• Created: 15/Jul/09 14:15
• Updated: 15/Jul/09 14:35
• Resolved: 15/Jul/09 14:35

Description

DataStructure.pm contains 2 subs which perform the same function: get_computer_private_ip() and get_computer_private_ip_address().
get_computer_private_ip() calls another sub in utils.pm called get_ip_address_from_hosts().
get_computer_private_ip_address() is self-contained and newer.

DataStructure::get_computer_private_ip() should be removed as well as utils.pm::get_ip_address_from_hosts(). This is the only place where get_ip_address_from_hosts() is called. Code calling get_computer_private_ip() should be changed to get_computer_private_ip_address().