VCL
  1. VCL
  2. VCL-118

Add delay to run_ssh_command() & run_scp_command() retry attempts

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.1
    • Component/s: vcld (backend)
    • Labels:
      None

      Description

      The run_ssh_command() and run_scp_command() subs in utils.pm make multiple attempts if the command fails. There is no delay between attempts. It will be beneficial to add a delay because it's possible the computer is booting up or services such as Cygwin sshd is starting up. Without a delay, all of the attempts may be made and then the computer becomes available.

      It would be good to have a progressive increase in the delay. The first to second attempt may not wait at all, then a couple seconds, then maybe 30 seconds on the last attempt. This amount of time is necessary because some things can take this long to initialize, such as running update_cygwin.cmd and configure_networking.vbs.

      1. utils.pm
        326 kB
        Otávio Augusto Araújo Silva

        Activity

        Hide
        Otávio Augusto Araújo Silva added a comment -

        I don't know if I can really contribute with the project, but costs nothing to try right...

        I added into run_ssh_command() and run_scp_command() subs in utils.pm the progressive delay after the first command fail , with 30 seconds in the max attempt.

        The progressive delay will be the result of 30/(max attempts/current attempt)

        Show
        Otávio Augusto Araújo Silva added a comment - I don't know if I can really contribute with the project, but costs nothing to try right... I added into run_ssh_command() and run_scp_command() subs in utils.pm the progressive delay after the first command fail , with 30 seconds in the max attempt. The progressive delay will be the result of 30/(max attempts/current attempt)

          People

          • Assignee:
            Andy Kurth
            Reporter:
            Andy Kurth
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 0.5h
              0.5h

                Development