[VALIDATOR-89] [validator] ValidatorAction needs thread-safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.1 Release

Environment

Operating System: All
Platform: All

• Bugzilla Id: 39393
• Assignee: Unassigned
• Reporter: Takayuki Kaneko
• Created: 24/Apr/06 20:49
• Updated: 12/Nov/07 19:25
• Resolved: 19/Jul/06 14:07

Description

ValidatorAction needs thread-safe because it is cached by other programs, like
Struts.
But ValidatorAction has an unthread-safe block.

Here is a patch below.

• • • ValidatorAction.java Mon Apr 24 22:41:55 2006
    • ValidatorAction.java.new Mon Apr 24 22:44:54 2006
      ***************
    • 527,536 ****
      params.put(Validator.VALIDATOR_ACTION_PARAM, this);

try {
! ClassLoader loader = this.getClassLoader(params);
! this.loadValidationClass(loader);
! this.loadParameterClasses(loader);
! this.loadValidationMethod();

Object[] paramValues = this.getParameterValues(params);

— 527,540 ----
params.put(Validator.VALIDATOR_ACTION_PARAM, this);

try {
! if (this.validationMethod == null) {
! synchronized(this)

{ ! ClassLoader loader = this.getClassLoader(params); ! this.loadValidationClass(loader); ! this.loadParameterClasses(loader); ! this.loadValidationMethod(); ! }

! }

Object[] paramValues = this.getParameterValues(params);