Commons Validator
  1. Commons Validator
  2. VALIDATOR-49

[Validator] ValidatorResult.getActionMap() or ValidatorResult.getActions() only contain last run dependency per field

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      When calling ValidatorResult#getActionMap() on a ValidatorResult Object
      associated with a Field which depends on several ValidatorActions, only the last
      ValidatorAction will be present in the returned Map / Iterator.

      A fix for this appears to be moving the line

      844: ValidatorResults results = new ValidatorResults();

      in the org.apache.commons.validator.Field class up to outside the dependencies
      loop, putting it as:

      835: ValidatorResults results = new ValidatorResults();

      No patch submitted for this yet and no Unit Test written. Will try to do so if
      time permits.

      This bug is also reported to the Commons mailing list at
      http://mail-archives.apache.org/mod_mbox/jakarta-commons-dev/200602.mbox/%3c43F45A7E.8080902@nascom.be%3e

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Resolved Resolved Closed Closed
        633d 21h 45m 1 Henri Yandell 12/Nov/07 19:25
        Henri Yandell made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Henri Yandell made changes -
        Assignee Jakarta Commons Developers Mailing List [ commons-dev@jakarta.apache.org ]
        Key COM-2770 VALIDATOR-49
        Affects Version/s unspecified [ 12311647 ]
        Component/s Validator [ 12311135 ]
        Project Commons [ 12310458 ] Commons Validator [ 12310494 ]
        Henri Yandell made changes -
        Field Original Value New Value
        issue.field.bugzillaimportkey 38678 12342922
        Hide
        Niall Pemberton added a comment -

        I have fixed this, thanks for reporting it and digging into the code to
        identify the probem.

        http://svn.apache.org/viewcvs?rev=384724&view=rev

        Closing as FIXED.

        Show
        Niall Pemberton added a comment - I have fixed this, thanks for reporting it and digging into the code to identify the probem. http://svn.apache.org/viewcvs?rev=384724&view=rev Closing as FIXED.
        bart vandendriessche created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            bart vandendriessche
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development