Uploaded image for project: 'Commons Validator'
  1. Commons Validator
  2. VALIDATOR-468

DomainValidator.getTLDArray does not synch mutable arrays

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.7
    • Component/s: None
    • Labels:
      None

      Description

      The method DomainValidator.getTLDEntries is currently unsynchronized.

      This means that there may be issues with the contents of the mutable override arrays.
      Although the arrays are marked volatile, that does not protect the array entries.

      Note: although #isValid() is not synchronised, this can only be used after calling a synchronised getInstance.

      AFAICT there is no point in leaving the arrays volatile.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sebb Sebb
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: