[VALIDATOR-418] UrlValidatorTest: testIsValid() does not run all tests

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6
• Assignee: Benedikt Ritter
• Reporter: Robert McGuigan
• Created: 13/Feb/17 23:38
• Updated: 22/Feb/17 16:36
• Resolved: 14/Feb/17 07:24

Description

The method testIsValid() does not iterate through all possible combinations of scheme, authority, etc. Namely, the last element in testUrlScheme is skipped. This is due to a bug in incrementTestPartsIndex, which returns false (indicating the maximum set of indices has been reached) prematurely.

Incidentally, the last test scheme currently present is the empty scheme "". This test case has been removed in the provided patch because the url string parser appears to assume that the scheme is nonempty. (e.g. if the scheme is empty, the scheme field will often be populated with the authority data).