Uploaded image for project: 'Commons Validator'
  1. Commons Validator
  2. VALIDATOR-344

AbstractCheckDigit class does not fully test invalid strings

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0 Release
    • Fix Version/s: 1.4.1 Release
    • Component/s: None
    • Labels:
      None

      Description

      The AbstractCheckDigit class does not fully test invalid check digits.

      There are several aspects to this:
      1. the createInvalidCodes method only checks for invalid digits - it does not try alphabetics, for example
      2. the "invalid" String array entries are passed unchanged to both the calculate() method - which expects a string without the check digit - and to the isValid() method, which expects the string to contain the check digit. As a result, only strings which are syntactically invalid will generate an Exception and thereby pass the test.
      3. testMissingCode does not call isInvalid() with a string length of 1. I assume the empty string should not have a check digit.

      Case 1) can be (partially) solved by including other printable characters in the generated output.

      Case 2) can (I think) be solved by assuming that the string always includes the check character, and stripping this off before passing it to calculate(). If the method does not throw an Exception, then the test must check that the calculated character does not agree. It may not be possible to check all types of invalid input this way, but at least it should be more robust than the current test case. Additional test cases can be added to separately test calculate() and isValid() if it proves necessary.

        Attachments

        1. Validator-344-1.patch
          1.0 kB
          Sebb

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                sebb Sebb
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: