[VALIDATOR-329] Checkdigit unit tests don't allow for invalid check digit checking

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 1.4.1 Release
• Assignee: Unassigned
• Reporter: Sebb
• Created: 24/Jan/14 12:56
• Updated: 13/Jan/15 20:02
• Resolved: 04/Jan/15 03:57

Description

The check digit unit tests are all based on the abstract class AbstractCheckDigitTest which performs various common checks based on the contents of the "valid" and "invalid" arrays.

The entries in the "invalid" array are checked by calling isValid() and also by calling calculate(). However the test assumes that the calculate() method will throw an exception. This means that the "invalid" array can only be used to test entries that have invalid characters etc, not entries which have a valid format but invalid check-digits.

Should probably introduce a new array which allows bad check-digits to be calculated independently

Issue Links

• duplicates: VALIDATOR-344 AbstractCheckDigit class does not fully test invalid strings
• relates to: VALIDATOR-344 AbstractCheckDigit class does not fully test invalid strings