[VALIDATOR-266] DomainValidator uses an O(n) method where an O(1) would be more appropriate

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.0 Release
• Fix Version/s: 1.4.1 Release
• Component/s: Routines
• Assignee: Benedikt Ritter
• Reporter: Chris Wareham
• Created: 17/Jun/08 11:27
• Updated: 13/Jan/15 20:02
• Resolved: 09/Nov/14 11:11

Description

The class org.apache.commons.validator.routines.DomainValidator contains several hard coded arrays of TLD names. Quite apart from whether these should be in a properties file rather than the source file itself, they are then used to populate List instances via Arrays.asList() and the List.contains() method used when validating a TLD. This is almost inevitably an O operation on each list, and could be improved by populating a single HashSet which would provide O(1) performance.