[VALIDATOR-259] [validator] Javascript jcv_handleErrors function fails in IE when field's ancestor is not visible

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.3.1 Release
• Component/s: JavaScript

Environment

Win XP, Sun JVM 1.4.2_x
Tomcat 4.1.x, Struts 1.3.8

• Assignee: Unassigned
• Reporter: Bas Zoetekouw
• Created: 11/Apr/08 01:28
• Updated: 07/Jan/15 00:07
• Resolved: 07/Jan/15 00:00

Description

If field is in hidden div (for example) than Javascript validation fails in IE with the following error:

"Error: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept focus."

jcv_handleErrors(messages, focusField) needs to be modified to traverse all parent nodes and check their visibility:

function jcv_handleErrors(messages, focusField) {
if (jcv_canFocus(focusField))

{ focusField.focus(); }

alert(messages.join('\n'));
}

function jcv_canFocus(field) {
var result = true;

if (field && field != null && typeof(field) != 'undefined') {
if (field.disabled || field.type == 'hidden')

{ result = false; }
if (result &&
field.style &&
field.style.visibility &&
field.style.visibility == 'hidden') { result = false; }

if (result) {
var parent = field.parentNode;
if (parent && parent != null && typeof(parent) != 'undefined' && parent.nodeType == 1)

{ result = jcv_canFocus(parent); }

}
} else

{ result = false; }

return result;
}

WORKAROUND:

1. Copy validateUtilities.js file from commons-validator-1.3.1.jar!\org\apache\commons\validator\javascript\validateUtilities.js into classpath under your control and apply patch above.

2. Modify validator-rules.xml:
<validator name="includeJavaScriptUtilities" classname="" method=""
methodParams="" depends="" msg=""
jsFunction="com.company.path.to.jsfile.validateUtilities" />

Issue Links

• relates to: VALIDATOR-97 [validator] Javascript mask validator fails when field is disabled