[VALIDATOR-252] Performance improvement of DomainValidator by change the regular expression

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4.0 Release
• Fix Version/s: 1.4.0 Release
• Component/s: Routines

Environment

Windows 2000 Professional, Pentium4 2.4GHz, RAM:512M, Eclipse 3.3m Junit 3.8.1

• Assignee: Ben Speakmon
• Reporter: Makoto Uchino
• Created: 29/Nov/07 01:50
• Updated: 30/Jan/14 14:13
• Resolved: 02/Dec/07 03:39

Description

It seemed to take very long time to match the regular expression when long TLD (consists of around 30-characters over TLD) was specified for DomainValidator, this exponential performance will make it appear that the program has hung.

The match time improves if it is possible to change DOMAIN_LABEL_REGEX from using

(?:) to (?>)

as follows.

DOMAIN_LABEL_REGEX = "\\p{Alnum}(?>[\\p{Alnum}-]*\\p{Alnum})*"

(All unit tests in DomainValidatorTest are succeed even if it changes as shown in the above-mentioned.)