Commons Validator
  1. Commons Validator
  2. VALIDATOR-191

Remove the dependency on Jakarta ORO (move to JDK 1.4 regular expression support)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0 Release, 1.3.0 Release, 1.3.1 Release
    • Fix Version/s: 1.4.0 Release
    • Component/s: Routines
    • Labels:
      None

      Description

      Hey,

      since Java 1.4 supports RegExpr. itself is it possible to remove the "org.apache.oro.text.perl.Perl5Util"
      from ISBNValidator?

      The org.apache.oro.** dependency is also there for the regExp validator.

      Any ideas on that?
      Or is this a "no no", since a Java 1.4 dep. is not suitable.

      Thanks,
      Matthias

      1. isbn_validator.patch
        0.9 kB
        Matthias Weßendorf

        Activity

        Matthias Weßendorf created issue -
        Hide
        Matthias Weßendorf added a comment -

        here a patch goes

        Show
        Matthias Weßendorf added a comment - here a patch goes
        Matthias Weßendorf made changes -
        Field Original Value New Value
        Attachment isbn_validator.patch [ 12335587 ]
        Hide
        Niall Pemberton added a comment -

        Its not a "no no" - I did a poll of JDK usage back in January and we discussed moving to a JDK 1.4 dependency then:

        Move to JDK 1.4: http://tinyurl.com/h3k6j
        Poll Result: http://tinyurl.com/h78zf

        Since then we have done the Validator 1.3.0 release, so I think we should do this in a Validator 1.4 version (nice coincidence

        From memory though its not just the ISBN validator - there is also the email address and url validators that depend on ORO.

        Show
        Niall Pemberton added a comment - Its not a "no no" - I did a poll of JDK usage back in January and we discussed moving to a JDK 1.4 dependency then: Move to JDK 1.4: http://tinyurl.com/h3k6j Poll Result: http://tinyurl.com/h78zf Since then we have done the Validator 1.3.0 release, so I think we should do this in a Validator 1.4 version (nice coincidence From memory though its not just the ISBN validator - there is also the email address and url validators that depend on ORO.
        Hide
        Matthias Weßendorf added a comment -

        there are some issues with the ISBNValitator test case for Java .14 RegExpr.
        Will take a look at it.

        Show
        Matthias Weßendorf added a comment - there are some issues with the ISBNValitator test case for Java .14 RegExpr. Will take a look at it.
        Hide
        Niall Pemberton added a comment -

        Need to remove the "/" from the start and end of the regular expression:

        private static final String ISBN_PATTERN =
        "^" + GROUP + SEP + PUBLISHER + SEP + TITLE + SEP + CHECK + "$";

        Show
        Niall Pemberton added a comment - Need to remove the "/" from the start and end of the regular expression: private static final String ISBN_PATTERN = "^" + GROUP + SEP + PUBLISHER + SEP + TITLE + SEP + CHECK + "$";
        Niall Pemberton made changes -
        Component/s Routines [ 12311270 ]
        Niall Pemberton made changes -
        Fix Version/s 1.4.0 [ 12312009 ]
        Hide
        Niall Pemberton added a comment -

        I'm changing the title of this issue to be more general since there are a number of validation routines using Jakarta ORO.

        I have moved and re-written ISBNValidator to the new routines package and the dependency on Jakarta ORO has now gone - see issue# VALIDATOR-188 for details about the new version
        http://svn.apache.org/viewvc?view=rev&revision=486765

        Now just need to do URL, Email and "mask" validators

        Show
        Niall Pemberton added a comment - I'm changing the title of this issue to be more general since there are a number of validation routines using Jakarta ORO. I have moved and re-written ISBNValidator to the new routines package and the dependency on Jakarta ORO has now gone - see issue# VALIDATOR-188 for details about the new version http://svn.apache.org/viewvc?view=rev&revision=486765 Now just need to do URL, Email and "mask" validators
        Niall Pemberton made changes -
        Summary ISBNValidator has dependency to org.apache.oro.text.perl.Perl5Util Remove the dependency on Jakarta ORO (move to JDK 1.4 regular expression support)
        Hide
        Ben Speakmon added a comment -

        Niall, I think we're done on this. You okay with resolving?

        Show
        Ben Speakmon added a comment - Niall, I think we're done on this. You okay with resolving?
        Hide
        Niall Pemberton added a comment -

        I'd like to review the whats left outside the "routines" package first.

        Show
        Niall Pemberton added a comment - I'd like to review the whats left outside the "routines" package first.
        Hide
        Nick Burch added a comment -

        Looks like the old style EmailValidator and UrlValidator are the last two users of ORO

        Show
        Nick Burch added a comment - Looks like the old style EmailValidator and UrlValidator are the last two users of ORO
        Hide
        Nick Burch added a comment -

        Dependency finally removed as of r1128484.

        Show
        Nick Burch added a comment - Dependency finally removed as of r1128484.
        Nick Burch made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Sebb made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Matthias Weßendorf
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development