[USERGRID-1243] Replace logging string concatenation with formatting

• Type: Story
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.0
• Sprint: Usergrid 33
• Assignee: Mike Dunker
• Reporter: Mike Dunker
• Created: 29/Jan/16 19:33
• Updated: 02/Feb/16 23:58
• Resolved: 02/Feb/16 16:53

Description

Concatenating strings when logging creates temporary strings that can have a negative effect on GC. Instead, log4j's string formatting functionality should be used.

Example:
Replace
logger.info("Invalid property value. name = " + name + ", value = " + value);
with
logger.info("Invalid property value. name = {}, value = {}", name, value);

Also:
1) Standardize on slf4j version 1.7.2, which includes variable argument support.
2) Remove extraneous object creation (for when variable argument support didn't exist).
3) Change debug statements for element creation/deletion, connections, etc. to trace.

Issue Links

• relates to: USERGRID-1043 Change any and all error messages akin to 'This should never happen' - because it happens