UIMA
  1. UIMA
  2. UIMA-708

fix maven build so eclipse:eclipse goal doesn't add src/main/resources/META-INF/LICENSE, NOTICES, and DISCLAIMER

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      Currently, every time you run eclipse:eclipse, the parent POM is configured for the life-cycle phase of generate-resources to run an ant script to copy the LICENSE, NOTICES, and DISCLAIMER files into the source tree, and because eclipse:eclipse runs the phases up to "generate-resources" (see http://maven.apache.org/plugins/maven-eclipse-plugin/eclipse-mojo.html where it says: "Invokes the execution of the lifecycle phase generate-resources prior to executing itself."), these files end up in the source tree, and need to be manually deleted.

      Change this to the maven-way of doing this: add a <resources> element to the parent POM that is configured to add these files to the meta-inf of the result.

      Adam said that he tried this earlier, and got strange failures. I just tried it and it seems to work now. I ran the whole build, both install and assembly:assembly. So, I think the prior issues have been resolved with the 2.0.7 level of Maven (current level is now 2.0.8).

        Activity

        Hide
        Marshall Schor added a comment -

        Found out that the after this change, the eclipse:eclipse plugin fails to set the right source classpath, and is instead setting the uimaj-distr readme as the src classpath. Reverting until can figure this out

        Show
        Marshall Schor added a comment - Found out that the after this change, the eclipse:eclipse plugin fails to set the right source classpath, and is instead setting the uimaj-distr readme as the src classpath. Reverting until can figure this out
        Hide
        Marshall Schor added a comment -

        These issues have been previously discovered and reported on - see http://issues.apache.org/jira/browse/UIMA-521 .

        The 3 files have to be in the source tree when generating sources using the maven goal source:jar (used to deploy to the maven repository.)

        The proper fix seems to be to leave things as is, but skip the copying if the goal is eclipse:eclipse.

        Show
        Marshall Schor added a comment - These issues have been previously discovered and reported on - see http://issues.apache.org/jira/browse/UIMA-521 . The 3 files have to be in the source tree when generating sources using the maven goal source:jar (used to deploy to the maven repository.) The proper fix seems to be to leave things as is, but skip the copying if the goal is eclipse:eclipse.
        Hide
        Marshall Schor added a comment -

        Fixed by moving the phase for doing this to process-resources, which after eclipse:eclipse stops the life cycle processing. Fixed some time ago.

        Show
        Marshall Schor added a comment - Fixed by moving the phase for doing this to process-resources, which after eclipse:eclipse stops the life cycle processing. Fixed some time ago.

          People

          • Assignee:
            Marshall Schor
            Reporter:
            Marshall Schor
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development