UIMA
  1. UIMA
  2. UIMA-521

Add LICENSE, DISCLAIMER, and NOTICES files to source jars produced by Maven

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.2
    • Labels:
      None

      Activity

      Hide
      Michael Baessler added a comment -

      After setting up a new workspace all works fine again.

      Show
      Michael Baessler added a comment - After setting up a new workspace all works fine again.
      Hide
      Adam Lally added a comment -

      This should be fixed now. I had to go back to using ant to get this to work. The Maven eclipse plugin doesn't support resource directories that are external to the component (it tries to add them as source folders in Eclipse, which does not work).

      Assigning to Michael to check if this fixes his Eclipse workspace. (I'm not sure but you might need to either do a fresh extract or else manually delete those extra files that mvn eclipse:eclipse created, since they will cause problems if you don't get rid of them.)

      Show
      Adam Lally added a comment - This should be fixed now. I had to go back to using ant to get this to work. The Maven eclipse plugin doesn't support resource directories that are external to the component (it tries to add them as source folders in Eclipse, which does not work). Assigning to Michael to check if this fixes his Eclipse workspace. (I'm not sure but you might need to either do a fresh extract or else manually delete those extra files that mvn eclipse:eclipse created, since they will cause problems if you don't get rid of them.)
      Hide
      Adam Lally added a comment -

      this fix broke mvn eclipse:eclipse

      Show
      Adam Lally added a comment - this fix broke mvn eclipse:eclipse
      Hide
      Marshall Schor added a comment -

      Verified this builds sources when you use
      mvn source:jar
      command. It puts the 3 files LICENSE, DISCLAIMER, and NOTICES in the jar one level higher than it does in the non-source jar. (In the non-source JAR, these 3 files are in the META-INF dir; here they're at the top level.) I don't think this is an issue.

      Note: The actual change is to replace custom "ant" code that was in here with the standard
      Maven way of doing things, which happens, as a nice side effect, to also enable the
      mvn source:jar
      command to work.

      Show
      Marshall Schor added a comment - Verified this builds sources when you use mvn source:jar command. It puts the 3 files LICENSE, DISCLAIMER, and NOTICES in the jar one level higher than it does in the non-source jar. (In the non-source JAR, these 3 files are in the META-INF dir; here they're at the top level.) I don't think this is an issue. Note: The actual change is to replace custom "ant" code that was in here with the standard Maven way of doing things, which happens, as a nice side effect, to also enable the mvn source:jar command to work.
      Hide
      Adam Lally added a comment -

      Fixed by updating the root uimaj pom.xml file. Assigned to Marshall to review since he pointed out the need for source jars to be published to Maven repo.

      Show
      Adam Lally added a comment - Fixed by updating the root uimaj pom.xml file. Assigned to Marshall to review since he pointed out the need for source jars to be published to Maven repo.

        People

        • Assignee:
          Michael Baessler
          Reporter:
          Adam Lally
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development