Uploaded image for project: 'UIMA'
  1. UIMA
  2. UIMA-3888

Remove stale pluginManagement section from UIMAJ SDK parent pom

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.0SDK
    • Labels:
      None

      Description

      We have a pretty stale pluginManagement section in the parent-pom of the UIMAJ SDK now. Just useless settings and commented out settings. Can we just remove this?

        <build>
          <pluginManagement>
            <plugins>
              <plugin>
                <artifactId>maven-changes-plugin</artifactId>
              </plugin>
              <plugin>
      	        <groupId>org.apache.maven.plugins</groupId>
      	        <artifactId>maven-compiler-plugin</artifactId>
      	        <configuration>
      	     <!--      <compilerId>javac-with-errorprone</compilerId>
      	          <forceJavacCompilerUse>true</forceJavacCompilerUse> -->
      	        </configuration>
      	  <!--  <dependencies>
      	          <dependency>
      	            <groupId>org.codehaus.plexus</groupId>
      	            <artifactId>plexus-compiler-javac</artifactId>
      	            <version>2.3</version>
      	          </dependency>
      	          <dependency>
      	            <groupId>org.codehaus.plexus</groupId>
      	            <artifactId>plexus-compiler-javac-errorprone</artifactId>
      	            <version>2.3</version>
      	          </dependency>
      	        </dependencies> -->
      	      </plugin>
            </plugins>
          </pluginManagement>
          <plugins>
              
          </plugins>
        </build>
      

        Activity

        Hide
        schor Marshall Schor added a comment -

        I'd like to leave that in, because it documents a bit of investigation I did once to explore possibly using a special java compiler that could find error-prone coding. I think at the time I tried it it wasn't ready for real use, so it's commented out. But it's a nice reminder in case someone at some point wants to investigate this again.

        If you've investigated this and found it's of no further interest (because it's dead-ended, or it's been supplanted by xxx, etc.), then, please comment on what you've found, for posterity and then it's fine with me to remove this.

        Show
        schor Marshall Schor added a comment - I'd like to leave that in, because it documents a bit of investigation I did once to explore possibly using a special java compiler that could find error-prone coding. I think at the time I tried it it wasn't ready for real use, so it's commented out. But it's a nice reminder in case someone at some point wants to investigate this again. If you've investigated this and found it's of no further interest (because it's dead-ended, or it's been supplanted by xxx, etc.), then, please comment on what you've found, for posterity and then it's fine with me to remove this.
        Hide
        rec Richard Eckart de Castilho added a comment -

        Is there an issue that documents the research that you did on this? If yes, it would be good to have a comment there with a link to the respective issue which documents how far this has proceeded and possibly why it is currently not further pursued.

        My impression is that findbugs and pmd cover quite a bit of error-prone coding. It seems to me that the error-prone compuler would be used most efficiently in IDE builds while findbugs/pmd work quite well in Maven builds [1]. After a brief look at their comparison, I think there is currently little to gain (if anything) by using this compiler in Maven builds.

        [1] https://code.google.com/p/error-prone/wiki/ComparisonWithFindbugs

        Show
        rec Richard Eckart de Castilho added a comment - Is there an issue that documents the research that you did on this? If yes, it would be good to have a comment there with a link to the respective issue which documents how far this has proceeded and possibly why it is currently not further pursued. My impression is that findbugs and pmd cover quite a bit of error-prone coding. It seems to me that the error-prone compuler would be used most efficiently in IDE builds while findbugs/pmd work quite well in Maven builds [1] . After a brief look at their comparison, I think there is currently little to gain (if anything) by using this compiler in Maven builds. [1] https://code.google.com/p/error-prone/wiki/ComparisonWithFindbugs
        Hide
        schor Marshall Schor added a comment -

        I think its fine to remove it, since the important things to have documented are now in this Jira

        Show
        schor Marshall Schor added a comment - I think its fine to remove it, since the important things to have documented are now in this Jira

          People

          • Assignee:
            rec Richard Eckart de Castilho
            Reporter:
            rec Richard Eckart de Castilho
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development