[UIMA-3567] addSourceToJars.bat has numerous errors

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.0SDK
• Fix Version/s: 2.6.0SDK
• Component/s: Build, Packaging and Test
• Labels: easyfix

Environment

Windows 7, Java 7.

• Assignee: Marshall Schor
• Reporter: John M. Boyer
• Created: 21/Jan/14 05:38
• Updated: 21/Jan/14 15:20
• Resolved: 21/Jan/14 15:20

Description

There are three error types in addSourceToJars.bat and one error in the documentation overview_and_setup.pdf section 3.3.
The doc says to go to the root directory of the source distribution to run addSourceToJars. However, this batch file is no longer at the root directory. It is now under the following additional subdirectories: src main readme_src

As a result, first error is that the line
cd jVinci\src\main\java
should be changed to
cd ..\..\..\jVinci\src\main\java

The second problem is that a typical installation of Java is installed to Program Files, which contains spaces. Therefore, the following line causes unexpected symbols that result in unsuccessful termination of the batch file.
if "%JAVA_HOME%"=="" (set UIMA_JAR_CALL=jar) else (set UIMA_JAR_CALL=%JAVA_HOME%\bin\jar)

To fix, it is necessary to surround the second occurrence of %JAVA_HOME% in quotes, like this:
if "%JAVA_HOME%"=="" (set UIMA_JAR_CALL=jar) else (set UIMA_JAR_CALL="%JAVA_HOME%"\bin\jar)

However, the quotes seem to carry over into the use of UIMA_JAR_CALL, so it becomes necessary to fix the 8 occurrences of
"%UIMA_JAR_CALL%"
to remove the surrounding quotes, like this
%UIMA_JAR_CALL%