Uploaded image for project: 'Apache Twill'
  1. Apache Twill
  2. TWILL-238

Change TwillController restartInstances API

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: api
    • Labels:
      None

      Description

      Lets change signature from Future<String> restartInstances(String runnable, int instanceId, int... moreInstanceIds) to Future<String> restartInstances(String runnable, Interger instanceId, Integer... moreInstanceIds) so it will be easier to convert from collections to vararg

        Issue Links

          Activity

          Hide
          chtyim Terence Yim added a comment -

          Instead of changing, it is better to add one that takes Collection<Integer> to maintain compatibility.

          Show
          chtyim Terence Yim added a comment - Instead of changing, it is better to add one that takes Collection<Integer> to maintain compatibility.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user fonelor opened a pull request:

          https://github.com/apache/twill/pull/56

          implemented issue TWILL-238: restart instances with Set of Integers

          Implemented https://issues.apache.org/jira/browse/TWILL-238

          New method in TwillController to restart instances of runnable

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/fonelor/twill feature/238_restartinstances_api

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/twill/pull/56.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #56


          commit eb184e6aa727d93fce4e6e4e33c729eb09017750
          Author: Sergey Filippov <firstrolenof@yandex.ru>
          Date: 2017-07-08T11:24:22Z

          implemented issue TWILL-238: restart instances with Set of Integers


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user fonelor opened a pull request: https://github.com/apache/twill/pull/56 implemented issue TWILL-238 : restart instances with Set of Integers Implemented https://issues.apache.org/jira/browse/TWILL-238 New method in TwillController to restart instances of runnable You can merge this pull request into a Git repository by running: $ git pull https://github.com/fonelor/twill feature/238_restartinstances_api Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/56.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #56 commit eb184e6aa727d93fce4e6e4e33c729eb09017750 Author: Sergey Filippov <firstrolenof@yandex.ru> Date: 2017-07-08T11:24:22Z implemented issue TWILL-238 : restart instances with Set of Integers
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fonelor commented on the issue:

          https://github.com/apache/twill/pull/56

          Thank you, serranom, for your comment. Is there any way to set "right" order of imports in IDEA? I've imported settings from HowToContribute page, but it seems, that it still wants to move imports.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fonelor commented on the issue: https://github.com/apache/twill/pull/56 Thank you, serranom, for your comment. Is there any way to set "right" order of imports in IDEA? I've imported settings from HowToContribute page, but it seems, that it still wants to move imports.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user chtyim commented on a diff in the pull request:

          https://github.com/apache/twill/pull/56#discussion_r126296669

          — Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java —
          @@ -17,15 +17,14 @@
          */
          package org.apache.twill.api;

          -import org.apache.twill.api.logging.LogEntry;
          -import org.apache.twill.api.logging.LogHandler;
          -import org.apache.twill.discovery.Discoverable;
          -import org.apache.twill.discovery.ServiceDiscovered;
          -
          import java.util.Map;
          import java.util.Set;
          import java.util.concurrent.Future;
          import javax.annotation.Nullable;
          +import org.apache.twill.api.logging.LogEntry;
          — End diff –

          Please don't rearrange the imports. You can use the ide profiles available in http://twill.apache.org/HowToContribute.html

          Show
          githubbot ASF GitHub Bot added a comment - Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/56#discussion_r126296669 — Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java — @@ -17,15 +17,14 @@ */ package org.apache.twill.api; -import org.apache.twill.api.logging.LogEntry; -import org.apache.twill.api.logging.LogHandler; -import org.apache.twill.discovery.Discoverable; -import org.apache.twill.discovery.ServiceDiscovered; - import java.util.Map; import java.util.Set; import java.util.concurrent.Future; import javax.annotation.Nullable; +import org.apache.twill.api.logging.LogEntry; — End diff – Please don't rearrange the imports. You can use the ide profiles available in http://twill.apache.org/HowToContribute.html
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fonelor commented on a diff in the pull request:

          https://github.com/apache/twill/pull/56#discussion_r127425262

          — Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java —
          @@ -17,15 +17,14 @@
          */
          package org.apache.twill.api;

          -import org.apache.twill.api.logging.LogEntry;
          -import org.apache.twill.api.logging.LogHandler;
          -import org.apache.twill.discovery.Discoverable;
          -import org.apache.twill.discovery.ServiceDiscovered;
          -
          import java.util.Map;
          import java.util.Set;
          import java.util.concurrent.Future;
          import javax.annotation.Nullable;
          +import org.apache.twill.api.logging.LogEntry;
          — End diff –

          i've reverted reformatting changes

          Show
          githubbot ASF GitHub Bot added a comment - Github user fonelor commented on a diff in the pull request: https://github.com/apache/twill/pull/56#discussion_r127425262 — Diff: twill-api/src/main/java/org/apache/twill/api/TwillController.java — @@ -17,15 +17,14 @@ */ package org.apache.twill.api; -import org.apache.twill.api.logging.LogEntry; -import org.apache.twill.api.logging.LogHandler; -import org.apache.twill.discovery.Discoverable; -import org.apache.twill.discovery.ServiceDiscovered; - import java.util.Map; import java.util.Set; import java.util.concurrent.Future; import javax.annotation.Nullable; +import org.apache.twill.api.logging.LogEntry; — End diff – i've reverted reformatting changes
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fonelor commented on the issue:

          https://github.com/apache/twill/pull/56

          Reverted reformatting

          Show
          githubbot ASF GitHub Bot added a comment - Github user fonelor commented on the issue: https://github.com/apache/twill/pull/56 Reverted reformatting
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user chtyim commented on the issue:

          https://github.com/apache/twill/pull/56

          LGTM.

          Show
          githubbot ASF GitHub Bot added a comment - Github user chtyim commented on the issue: https://github.com/apache/twill/pull/56 LGTM.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/twill/pull/56

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/56

            People

            • Assignee:
              rolenof Filippov Sergey
              Reporter:
              rolenof Filippov Sergey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development