Tuscany
  1. Tuscany
  2. TUSCANY-848

Some files missing the Apache license header

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: Cpp-M2
    • Fix Version/s: Cpp-M2
    • Component/s: C++ SCA, C++ SDO
    • Labels:
      None

      Description

      In both the source and bin distributions, the following files are missing the Apache license header:

      SCA GettingStarted.html and samples/GettingStarted.html.
      In both SCA and SDO, all the Makefile.am files.
      In both SCA and SDO, doc/css/maven-base.css and maven-theme.css.
      SCA xsd/readme.txt.
      SCA, the two package.html file in scagen.jar.

      And in the source distributions:
      In both SCA and SDO configure.ac

      Under SDO runtime/core/test/ a number of .txt, .xs, .wsdl test files:
      48736_xml.txt
      48736_xsd.txt
      StockQuoteService.wsdl
      b46633.txt
      b46634_out.txt
      b47137.txt
      b47137b.txt
      b47293.txt
      b48633_xml.txt
      b48633b_xsd.txt
      b48636_xml.txt
      b48636_xsd.txt
      b48686_xml.txt
      b48686_xsd.txt
      badelement.txt
      bothgroups_xsd.txt
      bothgroupssamename_xsd.txt
      bug2.txt
      bug45933-output.txt
      bug48300_xml.txt
      bug48300_xsd.txt
      bunique-out.txt
      bunique-out.xsd_safe.txt
      bunique-outxml.txt
      buniqueread-out.txt
      calculator2.wsdl
      calculator2a.wsdl
      carotest3.txt
      csload-output.txt
      csload2-output.txt
      csload3-output.txt
      cssave-output.txt
      cssave2-output.txt
      datetest.txt
      defaults.txt
      doctest.txt
      emptycs1.txt
      emptycs2.txt
      emptycs3.txt
      getproptest.txt
      groupingroup_xsd.txt
      grouprefingroup_xsd.txt
      grouptoolate_xsd.txt
      groupwithprefix_xsd.txt
      inc1.txt
      inc2.txt
      jira490.txt
      jira705.xsd
      jira705_out.txt
      list1_xml.txt
      list1_xsd.txt
      loadload-output.txt
      maintest.txt
      matttest1.txt
      merle1.txt
      notns.txt
      nulltest.txt
      oddchars.txt
      openloadNSout.txt
      openseq.txt
      order1.txt
      order2.txt
      querytest.txt
      saveopen-output.txt
      scenario1.txt
      scenario2.txt
      scenario3.txt
      scenario4.txt
      scenario5.txt
      sequence.txt
      setmany.txt
      setnull.txt
      showdefault1.txt
      showdefault2.txt
      simple.txt
      stock.wsdl
      stock_wsdl.txt
      stock_xml.txt
      testabstract.txt
      testerrors.txt
      testinc2.txt
      testopen.txt
      testorder.txt
      teststyles.txt
      testsubsload.txt
      testutils.txt
      testwsdl.txt
      travel.txt
      userdata.txt
      xhtml1.xsd
      xhtml_out.txt

      To run the ARAT tool, get it from svn checkout http://arat.googlecode.com/svn/trunk/ arat, build it with Ant (you just need the JDK and Ant) then run java -jar rat-0.1-SNAPSHOT.jar <directory-to-scan>. It will produce a report showing the licenses and notices that it finds. Violations are marked with a '!'. The tool incorrectly reports violations on binary files and the INSTALL files which I think are OK (I have not found an Apache project with a license at the top of its INSTALL file).

        Activity

        Jean-Sebastien Delfino made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Jean-Sebastien Delfino added a comment -

        Closing the issue now that it has been resolved.

        Show
        Jean-Sebastien Delfino added a comment - Closing the issue now that it has been resolved.
        Pete Robbins made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Pete Robbins committed 464548 (1 file)
        Reviews: none

        TUSCANY-848 delete unnecessary readme.txt

        Pete Robbins committed 464546 (1 file)
        Reviews: none

        TUSCANY-848 update test input file

        Pete Robbins committed 464523 (75 files)
        Reviews: none

        TUSCANY-848 update licence info in input test xsd files

        tuscany trunk
        Pete Robbins committed 464519 (1 file)
        Reviews: none

        TUSCANY-848 Add readme for files without licence header

        Hide
        Pete Robbins added a comment -

        I have added the correct licence info to:

        SCA GettingStarted.html and samples/GettingStarted.html.
        In both SCA and SDO, all the Makefile.am files.
        In both SCA and SDO, doc/css/maven-base.css and maven-theme.css.

        SCA, the two package.html file in scagen.jar.

        And in the source distributions:
        In both SCA and SDO configure.ac

        Also I deleted the SCA xsd/readme.txt. which contains no useful info.

        The SDO runtime/core/test files that are input only have had licence headers added. The remaining files are "expected output" files and can be classed as "binary" and therefore do not need licence headers (see query I posted to general@incubator). I will list these files in a readme.txt in the runtime/core/test folder.

        Show
        Pete Robbins added a comment - I have added the correct licence info to: SCA GettingStarted.html and samples/GettingStarted.html. In both SCA and SDO, all the Makefile.am files. In both SCA and SDO, doc/css/maven-base.css and maven-theme.css. SCA, the two package.html file in scagen.jar. And in the source distributions: In both SCA and SDO configure.ac Also I deleted the SCA xsd/readme.txt. which contains no useful info. The SDO runtime/core/test files that are input only have had licence headers added. The remaining files are "expected output" files and can be classed as "binary" and therefore do not need licence headers (see query I posted to general@incubator). I will list these files in a readme.txt in the runtime/core/test folder.
        Pete Robbins committed 464505 (72 files)
        Reviews: none

        TUSCANY-848 licence in Makefile.am files

        tuscany trunk
        Pete Robbins committed 464490 (4 files)
        Pete Robbins made changes -
        Assignee Pete Robbins [ robbinspg ]
        Hide
        Pete Robbins added a comment -

        I'm not sure how we fix the SDO test files. These are files that show the expected output of SDO serialisation and the like. The expected output will never contain a licence header. It seems odd that these files need the licence.

        Show
        Pete Robbins added a comment - I'm not sure how we fix the SDO test files. These are files that show the expected output of SDO serialisation and the like. The expected output will never contain a licence header. It seems odd that these files need the licence.
        Jean-Sebastien Delfino made changes -
        Description The following files are missing the Apache license header:

        SCA GettingStarted.html and samples/GettingStarted.html.
        In both SCA and SDO, all the Makefile.am files.
        In both SCA and SDO, doc/css/maven-base.css and maven-theme.css.
        SCA xsd/readme.txt.
        SCA, the two package.html file in scagen.jar.




        In both the source and bin distributions, the following files are missing the Apache license header:

        SCA GettingStarted.html and samples/GettingStarted.html.
        In both SCA and SDO, all the Makefile.am files.
        In both SCA and SDO, doc/css/maven-base.css and maven-theme.css.
        SCA xsd/readme.txt.
        SCA, the two package.html file in scagen.jar.

        And in the source distributions:
        In both SCA and SDO configure.ac

        Under SDO runtime/core/test/ a number of .txt, .xs, .wsdl test files:
        48736_xml.txt
        48736_xsd.txt
        StockQuoteService.wsdl
        b46633.txt
        b46634_out.txt
        b47137.txt
        b47137b.txt
        b47293.txt
        b48633_xml.txt
        b48633b_xsd.txt
        b48636_xml.txt
        b48636_xsd.txt
        b48686_xml.txt
        b48686_xsd.txt
        badelement.txt
        bothgroups_xsd.txt
        bothgroupssamename_xsd.txt
        bug2.txt
        bug45933-output.txt
        bug48300_xml.txt
        bug48300_xsd.txt
        bunique-out.txt
        bunique-out.xsd_safe.txt
        bunique-outxml.txt
        buniqueread-out.txt
        calculator2.wsdl
        calculator2a.wsdl
        carotest3.txt
        csload-output.txt
        csload2-output.txt
        csload3-output.txt
        cssave-output.txt
        cssave2-output.txt
        datetest.txt
        defaults.txt
        doctest.txt
        emptycs1.txt
        emptycs2.txt
        emptycs3.txt
        getproptest.txt
        groupingroup_xsd.txt
        grouprefingroup_xsd.txt
        grouptoolate_xsd.txt
        groupwithprefix_xsd.txt
        inc1.txt
        inc2.txt
        jira490.txt
        jira705.xsd
        jira705_out.txt
        list1_xml.txt
        list1_xsd.txt
        loadload-output.txt
        maintest.txt
        matttest1.txt
        merle1.txt
        notns.txt
        nulltest.txt
        oddchars.txt
        openloadNSout.txt
        openseq.txt
        order1.txt
        order2.txt
        querytest.txt
        saveopen-output.txt
        scenario1.txt
        scenario2.txt
        scenario3.txt
        scenario4.txt
        scenario5.txt
        sequence.txt
        setmany.txt
        setnull.txt
        showdefault1.txt
        showdefault2.txt
        simple.txt
        stock.wsdl
        stock_wsdl.txt
        stock_xml.txt
        testabstract.txt
        testerrors.txt
        testinc2.txt
        testopen.txt
        testorder.txt
        teststyles.txt
        testsubsload.txt
        testutils.txt
        testwsdl.txt
        travel.txt
        userdata.txt
        xhtml1.xsd
        xhtml_out.txt

        To run the ARAT tool, get it from svn checkout http://arat.googlecode.com/svn/trunk/ arat, build it with Ant (you just need the JDK and Ant) then run java -jar rat-0.1-SNAPSHOT.jar <directory-to-scan>. It will produce a report showing the licenses and notices that it finds. Violations are marked with a '!'. The tool incorrectly reports violations on binary files and the INSTALL files which I think are OK (I have not found an Apache project with a license at the top of its INSTALL file).
        Jean-Sebastien Delfino made changes -
        Summary GettingStarted.html and Makefile.am files missing the Apache license header Some files missing the Apache license header
        Jean-Sebastien Delfino made changes -
        Field Original Value New Value
        Component/s C++ SDO [ 12310663 ]
        Summary GettingStarted.html missing the Apache license header GettingStarted.html and Makefile.am files missing the Apache license header
        Description In the SCA binary distribution, the following files are missing the Apache license header:

        GettingStarted.html and samples/GettingStarted.html.




        The following files are missing the Apache license header:

        SCA GettingStarted.html and samples/GettingStarted.html.
        In both SCA and SDO, all the Makefile.am files.
        In both SCA and SDO, doc/css/maven-base.css and maven-theme.css.
        SCA xsd/readme.txt.
        SCA, the two package.html file in scagen.jar.




        Hide
        Jean-Sebastien Delfino added a comment -

        Added results of scanning the distribution with the Release Audit tool found at http://code.google.com/p/arat/.

        Show
        Jean-Sebastien Delfino added a comment - Added results of scanning the distribution with the Release Audit tool found at http://code.google.com/p/arat/ .
        Jean-Sebastien Delfino created issue -

          People

          • Assignee:
            Pete Robbins
            Reporter:
            Jean-Sebastien Delfino
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development