Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: Future Ideas
    • Component/s: None
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      Implement the implementation-scala-runtime module

      1. 3898-tuscany-guilherme
        32 kB
        Guilherme Moraes Armigliatto

        Activity

        ant elder made changes -
        Fix Version/s Future Ideas [ 12317619 ]
        Hide
        Simon Laws added a comment -

        Hi Guilherme.

        I committed this patch but subsequently noticed that it doesn't look like you checked the "Grant license to ASF for inclusion in ASF works (as per the Apache License §5) " check box. At least I don't think you did but it's a little difficult to tell with the new JIRA GUI. I need to see that checked to keep the code in the code base as it's saying that you have appropriate rights to the code changes in order to contribute them to Apache. Can you re-attach the patch with that box checked please. Remember to check that box for subsequent patches.

        On the patch itself. Be sure to add the Apache header to any source files you create. You missed one from ScalaException. I note the providers are not yet wired up to create the invoker so keep the patches coming. I look forward to seeing you add a test case!

        Simon

        Show
        Simon Laws added a comment - Hi Guilherme. I committed this patch but subsequently noticed that it doesn't look like you checked the "Grant license to ASF for inclusion in ASF works (as per the Apache License §5) " check box. At least I don't think you did but it's a little difficult to tell with the new JIRA GUI. I need to see that checked to keep the code in the code base as it's saying that you have appropriate rights to the code changes in order to contribute them to Apache. Can you re-attach the patch with that box checked please. Remember to check that box for subsequent patches. On the patch itself. Be sure to add the Apache header to any source files you create. You missed one from ScalaException. I note the providers are not yet wired up to create the invoker so keep the patches coming. I look forward to seeing you add a test case! Simon
        Guilherme Moraes Armigliatto made changes -
        Field Original Value New Value
        Attachment 3898-tuscany-guilherme [ 12486542 ]
        Guilherme Moraes Armigliatto created issue -

          People

          • Assignee:
            Guilherme Moraes Armigliatto
            Reporter:
            Guilherme Moraes Armigliatto
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development