[TUSCANY-3791] Concurrent access to a DOM Node can result in and NPE

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: Java-SCA-2.0
• Component/s: SCA Java Runtime
• Environment: All
• Assignee: Simon Laws
• Reporter: Simon Laws
• Created: 18/Nov/10 09:47
• Updated: 14/Sep/11 08:28
• Resolved: 14/Sep/11 08:28

Description

There are some cases where a DOM node is accessed without synchronization, for example,

public class Node2JAXB extends BaseTransformer<Node, Object> implements PullTransformer<Node, Object> {
private JAXBContextHelper contextHelper;

public Node2JAXB(ExtensionPointRegistry registry)

{ contextHelper = JAXBContextHelper.getInstance(registry); }

public Object transform(Node source, TransformationContext context) {
if (source == null)
return null;
try

{ JAXBContext jaxbContext = contextHelper.createJAXBContext(context, false); Unmarshaller unmarshaller = jaxbContext.createUnmarshaller(); Object result = unmarshaller.unmarshal(source, JAXBContextHelper.getJavaType(context.getTargetDataType())); return JAXBContextHelper.createReturnValue(jaxbContext, context.getTargetDataType(), result); }

catch (Exception e)

{ throw new TransformationException(e); }

}

This is exacerbated in the properties case because the property factories don't cache the results of this transformation.