[TUSCANY-3698] JMS Binding erases the stack trace of RuntimeException's

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Java-SCA-1.5, Java-SCA-1.5.1, Java-SCA-1.6, Java-SCA-2.0-M1, Java-SCA-2.0-M2, Java-SCA-2.0-M3, Java-SCA-2.0-M4, Java-SCA-2.0-M5
• Fix Version/s: Java-SCA-1.6, Java-SCA-2.0-M5
• Component/s: Java SCA JMS Binding Extension
• Environment: Tuscany Java SCA 1.6; Windows XP SP3; JDK 1.6
• Patch Info: Patch Available
• Assignee: Unassigned
• Reporter: Padraig Myers
• Created: 30/Sep/10 10:53
• Updated: 06/Oct/10 16:26
• Resolved: 06/Oct/10 16:26

Description

In the file org.apache.tuscany.sca.binding.jms.provider.AbstractMessageProcessor there is a method createFaultMessage(), this method creates a JMS fault message from an exception that is passed into the method.
However if the messages is a RuntimeException a new exception is created, thereby losing the stack trace from the original exception.
The offending piece of code is
ObjectMessage message = session.createObjectMessage();
String causeMsg;
if (o instanceof RuntimeException)

{ message.setObject(new ServiceRuntimeException(o.getMessage())); }

else

{ // for a checked exception return the checked exception message.setObject(o); }

message.setBooleanProperty(JMSBindingConstants.FAULT_PROPERTY, true);
return message;

there is no reason that RuntimeException's should be treated any differently and therefore the code above can be replaced with
ObjectMessage message = session.createObjectMessage();
message.setObject(o);
message.setBooleanProperty(JMSBindingConstants.FAULT_PROPERTY, true);
return message;

This means that the component that gets this JMS message will be able to log the true source of the exception and not lose all the stack trace information.