[TUSCANY-2966] Adjust binding.jms code since JMS BytesMessage bytes payload can only be read once

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: Java-SCA-1.x
• Component/s: Java SCA JMS Binding Extension
• Assignee: Simon Laws
• Reporter: Scott Kurz
• Created: 15/Apr/09 13:51
• Updated: 19/Sep/10 11:31
• Resolved: 26/Apr/09 12:17

Description

If we were to have each of an operationSelector and a wireFormat interceptor process a BytesMessage, then we would have a problem as the readBytes() method on the BytesMessage can only be called once, (at least in working with WebSphere Platform Messaging, not sure what the JMS spec says).

So the code currently in OperationSelectorJMSDefaultServiceInterceptor (as of r765178), would not be able to do the readBytes and then later have the WireFormat interceptor read the bytes, as the cursor would already be at the end of the message. (Actually as OperationSelectorJMSDefaultServiceInterceptor is written today, you couldn't easily recreate this bug, as we only look at the bytes if we have textXML wireFormat, but we would never have this with a BytesMessage. I only noticed the problem in making some additional local changes).

Probably the requestBytes/responseBytes need to be added to the JMSBindingContext or something like that...