Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.2
    • Component/s: None
    • Labels:
      None
    • Environment:

      OpenBSD

      Description

      Bunch of patches.

        Activity

        Hide
        Piotr Sikora added a comment -

        Hey Leif,
        it looks that the changes you've made to patch 0011 in #1215555, that is, adding:

        const_cast<const time_t *>
        

        instead of:

        (const time_t *)
        

        don't really work and build fails with:

        SysAPI.cc: In function 'int Time_GetTime(char*, size_t, char*, size_t, char*, size_t)':
        SysAPI.cc:651: error: invalid const_cast from type 'long int*' to type 'const time_t*'
        SysAPI.cc: In function 'int Time_GetDate(char*, size_t, char*, size_t, char*, size_t)':
        SysAPI.cc:691: error: invalid const_cast from type 'long int*' to type 'time_t*'
        ConfigCmd.cc: In function 'int ConfigDate(char*)':
        ConfigCmd.cc:2645: error: invalid const_cast from type 'long int*' to type 'const time_t*'
        ConfigCmd.cc: In function 'int ConfigTime(char*)':
        ConfigCmd.cc:2729: error: invalid const_cast from type 'long int*' to type 'const time_t*'
        
        Show
        Piotr Sikora added a comment - Hey Leif, it looks that the changes you've made to patch 0011 in #1215555 , that is, adding: const_cast< const time_t *> instead of: ( const time_t *) don't really work and build fails with: SysAPI.cc: In function ' int Time_GetTime( char *, size_t, char *, size_t, char *, size_t)': SysAPI.cc:651: error: invalid const_cast from type ' long int *' to type ' const time_t*' SysAPI.cc: In function ' int Time_GetDate( char *, size_t, char *, size_t, char *, size_t)': SysAPI.cc:691: error: invalid const_cast from type ' long int *' to type 'time_t*' ConfigCmd.cc: In function ' int ConfigDate( char *)': ConfigCmd.cc:2645: error: invalid const_cast from type ' long int *' to type ' const time_t*' ConfigCmd.cc: In function ' int ConfigTime( char *)': ConfigCmd.cc:2729: error: invalid const_cast from type ' long int *' to type ' const time_t*'
        Hide
        Igor Galić added a comment -

        Any opinion if we should back-port this, so someone can create an OpenBSD port of 3.0.x-stable?

        Show
        Igor Galić added a comment - Any opinion if we should back-port this, so someone can create an OpenBSD port of 3.0.x-stable?
        Hide
        Leif Hedstrom added a comment -

        I've committed all these patches to the trunk. Thanks!

        Show
        Leif Hedstrom added a comment - I've committed all these patches to the trunk. Thanks!
        Hide
        bettydramit added a comment -

        good job

        Show
        bettydramit added a comment - good job
        Hide
        Leif Hedstrom added a comment -

        Just took a quick glance, but lets make sure we use the ats_ prefix for "core" code, and not use the ts_ prefix. The TS prefix is reserved for public APIs.

        Show
        Leif Hedstrom added a comment - Just took a quick glance, but lets make sure we use the ats_ prefix for "core" code, and not use the ts_ prefix. The TS prefix is reserved for public APIs.

          People

          • Assignee:
            Leif Hedstrom
            Reporter:
            Piotr Sikora
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development