Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.1.0
    • Fix Version/s: 3.1.1
    • Component/s: Network
    • Labels:
      None

      Description

      Add support for accept filters (Solaris) triggered by proxy.config.net.defer_accept

      1. accept_filter.patch
        2 kB
        Theo Schlossnagle

        Activity

        Hide
        Theo Schlossnagle added a comment -

        We need to create a new ticket for adding FreeBSD support. Only Solaris is supported in trunk now.


        Theo Schlossnagle
        http://lethargy.org/~jesus/

        Show
        Theo Schlossnagle added a comment - We need to create a new ticket for adding FreeBSD support. Only Solaris is supported in trunk now. – Theo Schlossnagle http://lethargy.org/~jesus/
        Hide
        Leif Hedstrom added a comment -

        Can this be closed ?

        Show
        Leif Hedstrom added a comment - Can this be closed ?
        Hide
        Leif Hedstrom added a comment -

        Looks good to me. The only minor thing would be that it could be nice to unify the code that fetches the config value into one place, instead of two with this patch. I'm talking about

        IOCORE_ReadConfigInteger(should_filter_int, "proxy.config.net.defer_accept");

        Which is also used in the section where we support defer accept for Linux. Not a huge deal.

        Show
        Leif Hedstrom added a comment - Looks good to me. The only minor thing would be that it could be nice to unify the code that fetches the config value into one place, instead of two with this patch. I'm talking about IOCORE_ReadConfigInteger(should_filter_int, "proxy.config.net.defer_accept"); Which is also used in the section where we support defer accept for Linux. Not a huge deal.

          People

          • Assignee:
            Theo Schlossnagle
            Reporter:
            Theo Schlossnagle
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development