[TS-759] Makefile handles $DESTDIR incorrectly

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 2.1.8
• Fix Version/s: 2.1.9
• Component/s: Build

Environment

ATS 2.1.8 tagged in SVN as of today

• Assignee: Leif Hedstrom
• Reporter: Arno Toell
• Created: 05/May/11 17:30
• Updated: 19/Aug/11 01:19
• Resolved: 05/May/11 18:34

Description

The Makefile does not honor GNU's $DESTDIR coding standard anymore (see http://www.gnu.org/prep/standards/standards.html#DESTDIR), many build environments depend on. This is a regression to ATS 2.1.7 which had not this problem, and I believe it was introduced as fix for TS-624 (didn't verify).

In proxy/config/Makefile.am there is now am install-exec-hook which causes this regression. This is trivially to fix though:

--- a/proxy/config/Makefile.am
+++ b/proxy/config/Makefile.am
@@ -53,5 +53,5 @@
        for dfltcfgfile in $(dist_sysconf_DATA) $(nodist_sysconf_DATA) ; \
        do \
                cfgfile=`echo $$dfltcfgfile | sed 's/\.default$$//'` ; \
-               test -f $(sysconfdir)/$$cfgfile || mv $(sysconfdir)/$$dfltcfgfile $(sysconfdir)/$$cfgfile ; \
+               test -f $(DESTDIR)/$(sysconfdir)/$$cfgfile || mv $(DESTDIR)/$(sysconfdir)/$$dfltcfgfile $(DESTDIR)/$(sysconfdir)/$$cfgfile ; \
        done