[TS-629] non-portable char vs integer comparisons

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.5
• Fix Version/s: 2.1.8
• Component/s: Portability

Environment

ARM/Maemo with gcc 4.2.1

• Assignee: Nick Kew
• Reporter: Nick Kew
• Created: 10/Jan/11 14:41
• Updated: 19/Aug/11 01:19
• Resolved: 06/Apr/11 01:31

Description

Several char comparisons fail with "always true" or "always false" on this platform:

iocore/cluster/ClusterHandlerBase.cc line 148 (is this needed? Under what circumstances can size_index be negative but not -1)

iocore/cluster/ClusterProcessor.cc lines 209/210/212 (as above?)

lib/ts/ParseRules.h line 193 and 253 (platform is fine if we test bitwise-AND 0x80 for negativity)

proxy/mgmt2/cluster/ClusterCom.cc line 2134 (casting EOF to char fixes it)

proxy/mgmt2/preparse/IPRange.cc line 112 (as above)