Traffic Server
  1. Traffic Server
  2. TS-538

Replace INK statistics API with TS statistics API

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: Documentation, TS API
    • Labels:
      None

      Description

      Almost all INK* APIs, as exposed in ts/ts.h, are now prefixed with a TS instead. There are two exceptions, for two deprecated APIs the name change does not apply

      INKStat*
      INKCoupledStat*

      These two sets of APIs and enums (etc.) stay with the INK* prefix, since they are deprecated.

      1. ink-2-ts.sh
        0.5 kB
        Leif Hedstrom

        Issue Links

          Activity

          Leif Hedstrom created issue -
          Hide
          Leif Hedstrom added a comment -

          Trivial script to help in the conversion from INK* to TS* for script (and possibly docs).

          Show
          Leif Hedstrom added a comment - Trivial script to help in the conversion from INK* to TS* for script (and possibly docs).
          Leif Hedstrom made changes -
          Field Original Value New Value
          Attachment ink-2-ts.sh [ 12459745 ]
          Igor Galić made changes -
          Assignee Igor Galić [ i.galic ]
          Hide
          Igor Galić added a comment -

          In the current revision of the documentation this is the case.
          We should however check if my renaming wasn't too zealous.

          Show
          Igor Galić added a comment - In the current revision of the documentation this is the case. We should however check if my renaming wasn't too zealous.
          Hide
          Leif Hedstrom added a comment -

          Moving these all to a "Doc 3.x" release version.

          Show
          Leif Hedstrom added a comment - Moving these all to a "Doc 3.x" release version.
          Leif Hedstrom made changes -
          Fix Version/s Doc 3.x [ 12316472 ]
          Fix Version/s 3.0.0 [ 12314754 ]
          Hide
          James Peach added a comment -

          Since the INK statistics API isn't deprecated, we should deprecate it and replace it with a TS statistics API.

          Show
          James Peach added a comment - Since the INK statistics API isn't deprecated, we should deprecate it and replace it with a TS statistics API.
          James Peach made changes -
          Summary All InkAPIs are now TSAPIs Replace INK statistics API with TS statistics API
          Fix Version/s 3.3.0 [ 12316495 ]
          Fix Version/s Doc 3.0 [ 12316472 ]
          Component/s TS API [ 12313111 ]
          James Peach made changes -
          Link This issue is related to TS-600 [ TS-600 ]
          Hide
          James Peach added a comment -

          OK, I just found TS-600.

          The INK stats api is marked deprecated in the headerdoc, but doesn't have the corresponding compiler attribute (which is why I missed it in my sweep.

          For 3.2 shall we just add the TS_DEPRECATED attribute, or rip it out altogether?

          Show
          James Peach added a comment - OK, I just found TS-600 . The INK stats api is marked deprecated in the headerdoc, but doesn't have the corresponding compiler attribute (which is why I missed it in my sweep. For 3.2 shall we just add the TS_DEPRECATED attribute, or rip it out altogether?
          Hide
          Igor Galić added a comment -

          In my opinion, we should axe it out.

          Show
          Igor Galić added a comment - In my opinion, we should axe it out.
          Hide
          Leif Hedstrom added a comment - - edited

          yeah, we could nuke them. The replacements I wrote are generally superior. I don't know if anyone is using the old stuff. The one thing the old APIs has, that the new ones doesn't, is what they call "coupled stats". I have no idea when that'd be useful, but if someone whines, we can add that to the new APIs (which uses librecords under the hood, like God intended).

          Show
          Leif Hedstrom added a comment - - edited yeah, we could nuke them. The replacements I wrote are generally superior. I don't know if anyone is using the old stuff. The one thing the old APIs has, that the new ones doesn't, is what they call "coupled stats". I have no idea when that'd be useful, but if someone whines, we can add that to the new APIs (which uses librecords under the hood, like God intended).
          James Peach made changes -
          Link This issue relates to TS-1271 [ TS-1271 ]
          James Peach made changes -
          Assignee Igor Galić [ i.galic ] James Peach [ jamespeach ]
          Hide
          Leif Hedstrom added a comment -

          btw, this is primarily a doc bug. Are the docs updated with the new APIs, and the old ones removed?

          Show
          Leif Hedstrom added a comment - btw, this is primarily a doc bug. Are the docs updated with the new APIs, and the old ones removed?
          Hide
          James Peach added a comment -

          I'm going to use this bug to remove INKStats. I added the deprecation tags for the 3.2.0 release. Docs should be generated from headerdoc?

          Show
          James Peach added a comment - I'm going to use this bug to remove INKStats. I added the deprecation tags for the 3.2.0 release. Docs should be generated from headerdoc?
          Hide
          James Peach added a comment -

          fc6f759 TS-538: Remove deprecated INKStats API

          Leif, please review

          Show
          James Peach added a comment - fc6f759 TS-538 : Remove deprecated INKStats API Leif, please review
          James Peach made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Leif Hedstrom made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          604d 5h 40m 1 James Peach 13/Jul/12 05:50
          Resolved Resolved Closed Closed
          327d 17h 52m 1 Leif Hedstrom 05/Jun/13 23:42

            People

            • Assignee:
              James Peach
              Reporter:
              Leif Hedstrom
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development