[TS-493] Return value from pcre_exec tested incorrectly

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.3
• Fix Version/s: 2.1.4
• Assignee: Alan M. Carroll
• Reporter: Alan M. Carroll
• Created: 20/Oct/10 22:01
• Updated: 25/Jan/11 05:07
• Resolved: 22/Oct/10 02:52

Description

proxy/ControlMatcher.cc:371

The return value of pcre_exec is checked against -1 for error. However, the return value -1 means "not found" which is not actually an error. If there is an error, different negative values are returned which this logic will interpret as success.