Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4906

CID 1363289: Error handling issues in lib/ts/HashMD5.cc

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 7.1.0
    • Component/s: Core
    • Labels:
      None

      Description

      From coverity:

      *** CID 1363289:  Error handling issues  (CHECKED_RETURN)
      /lib/ts/HashMD5.cc: 36 in ATSHashMD5::update(const void *, unsigned long)()
      30     }
      31     
      32     void
      33     ATSHashMD5::update(const void *data, size_t len)
      34     {
      35       if (!finalized) {
         CID 1363289:  Error handling issues  (CHECKED_RETURN)
         Calling "EVP_DigestUpdate" without checking return value (as is done elsewhere 4 out of 5 times).
      36         EVP_DigestUpdate(ctx, data, len);
      37       }
      38     }
      39     
      40     void
      41     ATSHashMD5::final(void)
      

        Attachments

          Activity

            People

            • Assignee:
              psudaemon Phil Sorber
              Reporter:
              zwoop Leif Hedstrom
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 50m
                50m