Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4779

Remove SET_CLOSE_ON_EXEC #ifdef's from socket code.

    XMLWordPrintableJSON

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: 7.0.0
    • Component/s: Network
    • Labels:
      None

      Description

      This appears to be set nowhere, and so effectively disables CLOEXEC. James Peach suggests we remove just the #ifdef's and thereby enable CLOEXEC. I agree with this approach, but it is a change in behavior.

      $ grep -ir CLOSE_ON_EXEC
      iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
      iocore/net/UnixConnection.cc:#ifdef SET_CLOSE_ON_EXEC
      iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
      iocore/net/Connection.cc:#ifdef SET_CLOSE_ON_EXEC
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                psudaemon Phil Sorber
                Reporter:
                psudaemon Phil Sorber
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 1h 20m
                  1h 20m