[TS-4744] ParentConsistentHash::selectParent may select the unavailable parent

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: Parent Proxy
• Assignee: John Rushford
• Reporter: xiangdong chen
• Created: 12/Aug/16 03:34
• Updated: 31/Aug/16 14:30
• Resolved: 31/Aug/16 14:29

Description

code :ParentConsistentHash.cc,begin at line 141
do { // search until we've selected a different parent.
prtmp = (pRecord *)fhash->lookup(NULL, &result->chashIter[last_lookup], &wrap_around[last_lookup], &hash);
if (prtmp)

{ pRec = (parents[last_lookup] + prtmp->idx); }

} while (prtmp && strcmp(prtmp->hostname, result->hostname) == 0);

fix it like this:
if (prtmp)
pRec = (parents[last_lookup] + prtmp->idx);
else //begin of added xdchen, line:143
pRec = NULL; //endof of added by xdchen

if (prtmp)

{ pRec = (parents[last_lookup] + prtmp->idx); Debug("parent_select", "Selected a new parent: %s.", pRec->hostname); }

else //begin of added xdchen, line:188
pRec = NULL; ////end of added xdchen

}

Issue Links

• links to: GitHub Pull Request #900
• links to: GitHub Pull Request #939