[TS-4609] uninitialized read in SDK_API_HttpTxnTransform

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: Tests
• Assignee: James Peach
• Reporter: James Peach
• Created: 28/Jun/16 23:04
• Updated: 07/Nov/16 23:27
• Resolved: 29/Jun/16 19:04

Description

Valgrind says:

==32449== Thread 4 [ET_NET 2]:
==32449== Conditional jump or move depends on uninitialised value(s)
==32449==    at 0x4C30C9E: __strstr_sse42 (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==32449==    by 0x4EF5B1: transform_hook_handler(tsapi_cont*, TSEvent, void*) (InkAPITest.cc:6818)
==32449==    by 0x4B3139: INKContInternal::handle_event(int, void*) (InkAPI.cc:1012)
==32449==    by 0x6D9E32: EThread::process_event(Event*, int) (I_Continuation.h:153)
==32449==    by 0x6DA321: EThread::execute() (UnixEThread.cc:230)
==32449==    by 0x6D9643: spawn_thread_internal(void*) (Thread.cc:84)
==32449==    by 0x6C18DC4: start_thread (in /usr/lib64/libpthread-2.17.so)
==32449==    by 0x79AFCEC: clone (in /usr/lib64/libc-2.17.so)
==32449==

The problem is an off-by one NUL terminating the response buffer in synclient_txn_read_response.

Issue Links

• links to: GitHub Pull Request #759