Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4397

Build on i386 fails due to lua_Integer type mismatch in traffic_manager metrics

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2.0, 7.0.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently building master at 4c3fe2aac5e6b45839238b4ae207dff798939e61 fails, because a call to bind_constant in metrics.cc uses int64_t type casting instead of the correct lua_Integer type.

      This causes the following compile error on i386:

      metrics.cc: In function ‘bool metrics_binding_initialize(BindingInstance&)’:
      metrics.cc:339:58: error: call of overloaded ‘bind_constant(const char [20], int64_t)’ is ambiguous
         binding.bind_constant("metrics.update.pass", int64_t(0));
                                                                ^
      metrics.cc:339:58: note: candidates are:
      In file included from metrics.cc:29:0:
      ../../lib/bindings/bindings.h:44:8: note: bool BindingInstance::bind_constant(const char*, lua_Integer)
         bool bind_constant(const char *name, lua_Integer value);
              ^
      ../../lib/bindings/bindings.h:45:8: note: bool BindingInstance::bind_constant(const char*, const char*)
         bool bind_constant(const char *name, const char *value);
              ^
      

      I have identified the problem and will provide a pull request on GitHub. Update: PR GH-607

        Attachments

          Activity

            People

            • Assignee:
              zwoop Leif Hedstrom
              Reporter:
              felixbuenemann Felix Buenemann
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: