Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4364

Remove some remnants from http/2 refactoring

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2.0, 7.0.0
    • Component/s: HTTP/2
    • Labels:

      Description

      It seems this code is no longer applicable, and we should remove it for clarity. It can wait until 7.0.0 though.

      HttpTransact::handle_response_keep_alive_headers(State *s, HTTPVersion ver, HTTPHdr *heads)
      {
      .
      .
      .
          // check that the client is HTTP 1.1 and the conf allows chunking
          if (s->client_info.http_version == HTTPVersion(1, 1) &&
              (s->txn_conf->chunking_enabled == 1 ||
               (s->state_machine->plugin_tag &&
                (!strcmp(s->state_machine->plugin_tag, "http/2") || !strncmp(s->state_machine->plugin_tag, "spdy", 4)))) &&
              // if we're not sending a body, don't set a chunked header regardless of server response
              !is_response_body_precluded(s->hdr_info.client_response.status_get(), s->method) &&
              // we do not need chunked encoding for internal error messages
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                shinrich Susan Hinrichs
                Reporter:
                zwoop Leif Hedstrom
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: