[TS-4201] OneWayTunnel::connection_closed callback handleEvent with wrong continuation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.2.0
• Component/s: Core, Tools
• Labels: review
• Assignee: Unassigned
• Reporter: Chao Xu
• Created: 14/Feb/16 12:30
• Updated: 19/Jul/16 20:16
• Resolved: 01/Mar/16 21:02

Description

the OneWayTunnel::connection_closed code below:

void
OneWayTunnel::connection_closed(int result)
{
  if (cont) {
#ifdef TEST
    cout << "OneWayTunnel::connection_closed() ... calling cont" << endl;
#endif
    cont->handleEvent(result ? VC_EVENT_ERROR : VC_EVENT_EOS, cont);
  } else {
    OneWayTunnel_free(this);
  }
}

cont->handleEvent(result ? VC_EVENT_ERROR : VC_EVENT_EOS, cont);

It calls cont->handleEvent with `cont'.

If `cont' is not NULL, the handleEvent will free this OneWayTunnel object.

In order to free OneWayTunnel object, `cont' should be replaced by `this'.