Traffic Server
  1. Traffic Server
  2. TS-418

AdminClient.pm has invalid package path, preventing it's use without modification.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.3
    • Component/s: Metrics
    • Labels:
      None

      Description

      AdminClient.pm found under 'contrib' in cvs (http://svn.apache.org/viewvc/trafficserver/traffic/trunk/contrib/) has a couple of issues.

      ---------
      1) there's no pod or perl documentation
      2) there's no MakeFile to help with placing AdminClient.pm in the proper directory so @INC will find it.
      3) the package statement is flawed as it's not in a Apache/TS/ directory structure. To use the current AdminClient.pm, one would need to modify the 'package' statement by hand.
      ---------

      I have a local copy where the above issues are fixed, but have questions about the v2 stats on port 8091. Specifically, will future stats use port 8091 (or whatever proxy.config.stat_collector.port is set to) or will stats continue to be read from the 'unix domain socket' which currently defaults to /usr/local/var/trafficserver/cli. If someone who knows can update this ticket, I can make those additions/changes before committing to SVN.

        Activity

        Hide
        Leif Hedstrom added a comment -

        My strong preference would be to eliminate port 8091, and only use the unix domain socket for all stats. Or at a minimum, there should only be one way of accessing "stats" and "configurations" from command line.

        I started working a little on a proposal for how to clean up the stats, there's a rough draft at

        https://cwiki.apache.org/confluence/display/TS/NewStatsAPI

        Show
        Leif Hedstrom added a comment - My strong preference would be to eliminate port 8091, and only use the unix domain socket for all stats. Or at a minimum, there should only be one way of accessing "stats" and "configurations" from command line. I started working a little on a proposal for how to clean up the stats, there's a rough draft at https://cwiki.apache.org/confluence/display/TS/NewStatsAPI
        Hide
        Adam Faris added a comment - - edited

        Here's a tar file containing the changes I mentioned. I'm submitting as a tar file as it contains a directory structure which was created by h2xs. I started to write this to be released to cpan but decided against it as there's no sense in having two copies of the same package floating around the internet. Also publishing to cpan would open other issues, like who from the dev team can upload updates to cpan; so yes, leave AdminClient with ATS. Anyway that's the reasoning behind the '-0.01' extension on the parent directory name.

        Part of h2xs process results in a Makefile which does the actual install of the module. The README has the details, but it seems reasonable that in the future we could incorporate that h2xs Makefile into the ATS install scripts. Let me know if I've overlooked something and I'll be happy to make the changes.

        Regarding port 8091, it's not being used by AdminClient. All requests are using the unix domain socket.

        Show
        Adam Faris added a comment - - edited Here's a tar file containing the changes I mentioned. I'm submitting as a tar file as it contains a directory structure which was created by h2xs. I started to write this to be released to cpan but decided against it as there's no sense in having two copies of the same package floating around the internet. Also publishing to cpan would open other issues, like who from the dev team can upload updates to cpan; so yes, leave AdminClient with ATS. Anyway that's the reasoning behind the '-0.01' extension on the parent directory name. Part of h2xs process results in a Makefile which does the actual install of the module. The README has the details, but it seems reasonable that in the future we could incorporate that h2xs Makefile into the ATS install scripts. Let me know if I've overlooked something and I'll be happy to make the changes. Regarding port 8091, it's not being used by AdminClient. All requests are using the unix domain socket.
        Hide
        Leif Hedstrom added a comment -

        Committed this, the new "tree" is

        contrib/perl
        └── AdminClient
        ├── Changes
        ├── lib
        │   └── Apache
        │   └── TS
        │   └── AdminClient.pm
        ├── Makefile.PL
        ├── MANIFEST
        ├── README
        └── t
        └── Apache-TS-AdminClient.t

        Show
        Leif Hedstrom added a comment - Committed this, the new "tree" is contrib/perl └── AdminClient ├── Changes ├── lib │   └── Apache │   └── TS │   └── AdminClient.pm ├── Makefile.PL ├── MANIFEST ├── README └── t └── Apache-TS-AdminClient.t

          People

          • Assignee:
            Leif Hedstrom
            Reporter:
            Adam Faris
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 25h
              25h
              Remaining:
              Remaining Estimate - 25h
              25h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development