Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4054

Incorrect ink_assert behavior in Diags.cc

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1.0
    • Component/s: Logging
    • Labels:
      None

      Description

      In `lib/ts/Diags.cc:setup_diagslog()`, the statement `ink_assert(diags_log == NULL)` is incorrect. It should instead be: `if (blf == NULL) return`

      We should not use an assert here either because when the function is passed a NULL `blf`, it means that some test doesn't want to use the diags.log log file and we should just not set up diagslog.

        Attachments

          Activity

            People

            • Assignee:
              danobi Daniel Xu
              Reporter:
              danobi Daniel Xu
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: