[TS-4044] Conflict conditions in HttpSM::do_http_server_open()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 7.0.0
• Component/s: HTTP
• Assignee: Susan Hinrichs
• Reporter: Chao Xu
• Created: 01/Dec/15 07:26
• Updated: 07/Nov/16 23:25
• Resolved: 06/Sep/16 19:06

Description

there is a conflict between the conditions of Line 4786 and 4797. I was wondering whether it is a bug

4786     if (t_state.method != HTTP_WKSIDX_CONNECT) {
4787       DebugSM("http", "calling netProcessor.connect_re");
4788       connect_action_handle = netProcessor.connect_re(this,                                 // state machine
4789                                                       &t_state.current.server->dst_addr.sa, // addr + port
4790                                                       &opt);
4791     } else {
4792       // Setup the timeouts
4793       // Set the inactivity timeout to the connect timeout so that we
4794       //   we fail this server if it doesn't start sending the response
4795       //   header
4796       MgmtInt connect_timeout;
4797       if (t_state.method == HTTP_WKSIDX_POST || t_state.method == HTTP_WKSIDX_PUT) {
4798         connect_timeout = t_state.txn_conf->post_connect_attempts_timeout;
4799       } else if (t_state.current.server == &t_state.parent_info) {
4800         connect_timeout = t_state.http_config_param->parent_connect_timeout;
4801       } else {
4802         if (t_state.pCongestionEntry != NULL)
4803           connect_timeout = t_state.pCongestionEntry->connect_timeout();
4804         else
4805           connect_timeout = t_state.txn_conf->connect_attempts_timeout;
4806       }
4807       DebugSM("http", "calling netProcessor.connect_s");
4808       connect_action_handle = netProcessor.connect_s(this,                                 // state machine
4809                                                      &t_state.current.server->dst_addr.sa, // addr + port
4810                                                      connect_timeout, &opt);
4811     }

Issue Links

• relates to: TS-3046 Phase out proxy.config.ssl.number.threads and force ET_NET threads to handle SSL connections
• relates to: TS-1883 TLS origin connections do not support connection timeouts