Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-4008

Cleanup SPDY ClientSessionSession / SpdyRequest Allocate and Deallocate code

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 6.1.0
    • Core, SPDY
    • None

    Description

      To make the SPDY classes SpdyClientSession and SpdyRequest conform with the rest of the code base's pattern of alloc()/destroy() we want to clean up that code in the following ways:

      • Removed custom dtors from SpdyClientSession and SpdyRequest
      • Implemented a uniform interface destroy() to both and refactored calls to clear() followed by ClassAllocator::free() with just destroy() to perform both.
      • Implemented a static function alloc() for both classes that will use the designated ClassAllocator to alloc() the object.

      This was also discussed in the pull request : https://github.com/apache/trafficserver/pull/323

      Attachments

        Activity

          People

            briang Brian Geffon
            briang Brian Geffon
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: