[TS-3696] Bad range check in HdrHeap

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Fix Version/s: 4.2.4, 5.3.1, 6.0.0
• Component/s: HTTP
• Assignee: Leif Hedstrom
• Reporter: Leif Hedstrom
• Created: 16/Jun/15 21:31
• Updated: 04/Feb/16 18:54
• Resolved: 16/Jun/15 22:48

Description

gcc 5.1 complains with

../../../proxy/hdrs/HdrHeap.cc: In member function 'void HdrHeap::inherit_string_heaps(const HdrHeap*)':
../../../proxy/hdrs/HdrHeap.cc:978:23: error: array subscript is above array bounds [-Werror=array-bounds]
     if (m_ronly_heap[z].m_heap_start == h_start) {
                       ^
cc1plus: all warnings being treated as errors
Makefile:677: recipe for target 'HdrHeap.o' failed
make[1]: *** [HdrHeap.o] Error 1

There's a check in the code to make sure *index is within the boundaries, but it is done too late.