Traffic Server
  1. Traffic Server
  2. TS-367

Remove HAVE_LIBSSL preproc tests because of mandatory openssl requirement

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.3
    • Component/s: Cleanup
    • Labels:
      None

      Description

      At least since version 2 configure will fail unless user
      has openssl-dev installed which makes openssl mandatory
      and which is fine.

      Any objection to remove the #ifdef HAVE_LIBSSL preproc
      tests since they are always true

        Activity

        Hide
        Mladen Turk added a comment -

        Patch to cleanup the HAVE_LIBSSL preproc tests

        Show
        Mladen Turk added a comment - Patch to cleanup the HAVE_LIBSSL preproc tests
        Hide
        Leif Hedstrom added a comment -

        Would it make sense to make SSL truly "optional" ? If so, maybe move this out for a "future" version, instead of nuking it? I'm OK either way, but my "preference" would be to make SSL optional.

        Show
        Leif Hedstrom added a comment - Would it make sense to make SSL truly "optional" ? If so, maybe move this out for a "future" version, instead of nuking it? I'm OK either way, but my "preference" would be to make SSL optional.
        Hide
        Mladen Turk added a comment -

        Target for 2.1.2 and make the OpenSSL optional.
        This requires to use the our own md5 in that case (port from APR)

        Show
        Mladen Turk added a comment - Target for 2.1.2 and make the OpenSSL optional. This requires to use the our own md5 in that case (port from APR)
        Hide
        Leif Hedstrom added a comment -

        Meh, lets just require OpenSSL, it's easier. +1 on just applying this patch, and remove the check entirely.

        Show
        Leif Hedstrom added a comment - Meh, lets just require OpenSSL, it's easier. +1 on just applying this patch, and remove the check entirely.
        Hide
        Leif Hedstrom added a comment -

        I committed this, thanks for the patch Mladen!

        Show
        Leif Hedstrom added a comment - I committed this, thanks for the patch Mladen!

          People

          • Assignee:
            Leif Hedstrom
            Reporter:
            Mladen Turk
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development