Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-3546

Force global plugin registration with TSPluginRegister API and remove version information

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.3.0
    • Fix Version/s: 6.0.0
    • Component/s: TS API
    • Labels:
      None

      Description

      IRC discussion about it:

      [09:29:39]  <@bcall>	why do we want plugins to register?
      [09:30:06]  <@jpeach>	afaik historically it's always been a requirement
      [09:30:30]  <@bcall>	I don't think so
      [09:30:33]  <@jpeach>	imho there should be a way for  plugin to fail at startup
      [09:30:53]  <@jpeach>	if register does nothing useful then we should just remove it
      [09:31:46]  <@bcall>	it was used for API version checking from what I remember
      [09:31:52]  <@jpeach>	but registration creates internal info that could be used for something interesting
      [09:31:54]  <@bcall>	and I never did it in my plugins
      [09:32:18]  <@sudheerv>	fwiw, i think i didn't either ;)
      [09:32:52]  <@jpeach>	heh
      [09:32:54]  <@bcall>	it is helpful for 3rd party plugins - vender, email, etc
      [09:33:13]  <@bcall>	and api version checking
      [09:33:14]  <@jpeach>	that information never goes anywhere
      [09:33:20]  <@bcall>	I can see the merit of the version checking
      [09:33:21]  <@jpeach>	the version checking does nothing
      [09:33:28]  <@bcall>	even better :)
      [09:33:40]  <@jpeach>	sounds like you should nuke it for 6.0
      [09:34:09]  <@bcall>	I will file a bug
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                bcall Bryan Call
                Reporter:
                bcall Bryan Call
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: