Traffic Server
  1. Traffic Server
  2. TS-345

Use localized apr_foo.m4 macros and config.layout system

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.1
    • Component/s: Build
    • Labels:
      None
    • Environment:

      Autoconf

      Description

      Here are the cleaned versions of apr_common.m4 and apr_network.m4 with ATS_ namespace.
      There is also proposed config.layout file that should default to the current layout
      However since it's include file one doesn't need to run the autoreconf for changes.

      1. configure.ac
        30 kB
        Mladen Turk
      2. network.m4
        3 kB
        Mladen Turk
      3. zlib.m4
        2 kB
        Mladen Turk
      4. lzma.m4
        2 kB
        Mladen Turk
      5. dbd.m4
        4 kB
        Mladen Turk
      6. common.m4
        14 kB
        Mladen Turk

        Issue Links

          Activity

          Mladen Turk created issue -
          Hide
          Mladen Turk added a comment -

          This is apr_common.m4 with modified APR_LAYOUT that uses trafficserver and fixes the pkg*foo autoconf macros

          Show
          Mladen Turk added a comment - This is apr_common.m4 with modified APR_LAYOUT that uses trafficserver and fixes the pkg*foo autoconf macros
          Mladen Turk made changes -
          Field Original Value New Value
          Attachment ats_common.m4 [ 12444122 ]
          Hide
          Mladen Turk added a comment -

          Cleaned up apr_network.m4

          Show
          Mladen Turk added a comment - Cleaned up apr_network.m4
          Mladen Turk made changes -
          Attachment ats_network.m4 [ 12444123 ]
          Hide
          Mladen Turk added a comment -

          Trafficserver layout file.
          All defines go here
          For each define that doesn't end with + the pkg

          {var}={var}

          /trafficserver is added unless configure already specified the trafficserver prefix.

          Show
          Mladen Turk added a comment - Trafficserver layout file. All defines go here For each define that doesn't end with + the pkg {var}={var} /trafficserver is added unless configure already specified the trafficserver prefix.
          Mladen Turk made changes -
          Attachment config.layout [ 12444124 ]
          Mladen Turk made changes -
          Attachment ats_common.m4 [ 12444122 ]
          Hide
          Mladen Turk added a comment -

          Updates ats_common.m4 with some macros form apr and httpd that allow
          to subst expanded vars which could be used instead current -DPKGLOCALSTATEDIR
          defines in a config.h file

          Show
          Mladen Turk added a comment - Updates ats_common.m4 with some macros form apr and httpd that allow to subst expanded vars which could be used instead current -DPKGLOCALSTATEDIR defines in a config.h file
          Mladen Turk made changes -
          Attachment ats_common.m4 [ 12444126 ]
          Mladen Turk made changes -
          Attachment ats_common.m4 [ 12444126 ]
          Mladen Turk made changes -
          Attachment ats_network.m4 [ 12444123 ]
          Mladen Turk made changes -
          Attachment config.layout [ 12444124 ]
          Hide
          Mladen Turk added a comment -

          First set of new macro files

          Show
          Mladen Turk added a comment - First set of new macro files
          Mladen Turk made changes -
          Attachment common.m4 [ 12444293 ]
          Attachment dbd.m4 [ 12444294 ]
          Attachment lzma.m4 [ 12444295 ]
          Mladen Turk made changes -
          Attachment zlib.m4 [ 12444296 ]
          Attachment network.m4 [ 12444297 ]
          Attachment configure.ac [ 12444298 ]
          Hide
          Mladen Turk added a comment -

          OK. This is heavy rewrite of configure.ac that allows more flexible configure

          Beside layout logic, new detection for required/optional libraries has been added that makes the common usage.
          By default sqlite3 is detected unless --without-sqlite3 has been specified. Then bdb is scanned, so no need to
          explicitly specify '--wihout-sqlite --with-libdb'

          Also all libraries have an option to specify custom location.

          Further more we use ATS_ADDTO(CPPFLAGS, foo) which will add foo unless already added

          Show
          Mladen Turk added a comment - OK. This is heavy rewrite of configure.ac that allows more flexible configure Beside layout logic, new detection for required/optional libraries has been added that makes the common usage. By default sqlite3 is detected unless --without-sqlite3 has been specified. Then bdb is scanned, so no need to explicitly specify '--wihout-sqlite --with-libdb' Also all libraries have an option to specify custom location. Further more we use ATS_ADDTO(CPPFLAGS, foo) which will add foo unless already added
          John Plevyak made changes -
          Fix Version/s 2.1.0 [ 12314485 ]
          Mladen Turk made changes -
          Link This issue blocks TS-280 [ TS-280 ]
          Leif Hedstrom made changes -
          Fix Version/s 2.1.1 [ 12314995 ]
          Fix Version/s 2.1.0 [ 12314485 ]
          Hide
          Mladen Turk added a comment -

          Layout work finished

          Show
          Mladen Turk added a comment - Layout work finished
          Mladen Turk made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Leif Hedstrom made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Workflow jira [ 12510515 ] TS Workflow [ 12522370 ]
          Gavin made changes -
          Link This issue blocks TS-280 [ TS-280 ]
          Gavin made changes -
          Link This issue is depended upon by TS-280 [ TS-280 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Resolved Resolved
          18d 1h 13m 1 Mladen Turk 28/May/10 19:05
          Resolved Resolved Closed Closed
          88d 8h 47m 1 Leif Hedstrom 25/Aug/10 03:53

            People

            • Assignee:
              Mladen Turk
              Reporter:
              Mladen Turk
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development