Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.1.0
    • Component/s: None
    • Labels:
      None

      Description

      There is still a lot of FTP code left, even though all support for FTP is gone. We should clean up these remnants.

      1. DIFF
        459 kB
        Leif Hedstrom

        Activity

        Hide
        Leif Hedstrom added a comment -

        Done.

        Show
        Leif Hedstrom added a comment - Done.
        Hide
        George Paul added a comment -

        Discussed this issue on IRC.
        +1 on patch. Good to go.
        -George

        Show
        George Paul added a comment - Discussed this issue on IRC. +1 on patch. Good to go. -George
        Hide
        Leif Hedstrom added a comment -

        This is a valid concern George, and I thought hard about this when I did the NNTP cleanup. My thinking is this: We had a few "hard coded" cases to handle NNTP, FTP and a few other "streaming" protocols (which we'll also need to cleanup next . This limited what a plugin could implement / use from the core to only those few protocols.

        By removing this entirely from the core, we'll have to rethink how a plugin would implement new handlers. There will without doubt have to be lots of changes into the core, and additions to InkAPI, but I'm convinced this is the right way to go. Let the plugin register protocols, additions to "logs" and cache and stats, all via well defined APIs in InkAPI. No more hardcoding "cases" into the core, lets fix it when we need this support once and for all.

        I hope that makes sense?

        Show
        Leif Hedstrom added a comment - This is a valid concern George, and I thought hard about this when I did the NNTP cleanup. My thinking is this: We had a few "hard coded" cases to handle NNTP, FTP and a few other "streaming" protocols (which we'll also need to cleanup next . This limited what a plugin could implement / use from the core to only those few protocols. By removing this entirely from the core, we'll have to rethink how a plugin would implement new handlers. There will without doubt have to be lots of changes into the core, and additions to InkAPI, but I'm convinced this is the right way to go. Let the plugin register protocols, additions to "logs" and cache and stats, all via well defined APIs in InkAPI. No more hardcoding "cases" into the core, lets fix it when we need this support once and for all. I hope that makes sense?
        Hide
        George Paul added a comment -

        Other than my comments above about leaving in the FTP support in the hdrs lib the patch looks good. Reviewed and tested on ubuntu904, FreeBSD(7.2), OpenSolaris(osol0906) and OSX(10.5).

        -George

        Show
        George Paul added a comment - Other than my comments above about leaving in the FTP support in the hdrs lib the patch looks good. Reviewed and tested on ubuntu904, FreeBSD(7.2), OpenSolaris(osol0906) and OSX(10.5). -George
        Hide
        George Paul added a comment -

        Can we leaf the FTP support in the 'hdrs' library i.e. 'proxy/hdrs'. I believe it would be best to leave protocol support where it is isolated in library in case someone wants to write a plugin for FTP support or reuse the 'hdrs' lib somewhere else.

        -George

        Show
        George Paul added a comment - Can we leaf the FTP support in the 'hdrs' library i.e. 'proxy/hdrs'. I believe it would be best to leave protocol support where it is isolated in library in case someone wants to write a plugin for FTP support or reuse the 'hdrs' lib somewhere else. -George
        Hide
        Leif Hedstrom added a comment -

        Proposed "diff" against trunk.

        Show
        Leif Hedstrom added a comment - Proposed "diff" against trunk.

          People

          • Assignee:
            Leif Hedstrom
            Reporter:
            Leif Hedstrom
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development