Uploaded image for project: 'Traffic Server'
  1. Traffic Server
  2. TS-3156

Mutex[Try]Lock bool() operator change and unused API removal

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 5.2.0
    • Core

    Description

      Removed unused constructor in MutexLock along with set_and_take() method, had to change FORCE_PLUGIN_MUTEX() for that. Removed release() method.

      default bool and ! operator from both MutexLock and MutexTryLock with is_locked() API. Changes if (lock) to if (lock.is_locked()) across the code base.

      Ran make test will be performing more system testing. Posted before for early comments / feedback.

      Attachments

        1. fix-MutexLock.patch
          4 kB
          Ryo Okubo
        2. MutexLock-ats.patch
          77 kB
          Powell Molleti
        3. MutexLock-ats.patch
          70 kB
          Powell Molleti
        4. Use-Ryo-s-patch-to-pass-shared_ptr-to-MutexLock.patch
          5 kB
          Powell Molleti

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. TS-3315 Assert after try lock

          • Major - Major loss of function.
          • Open

          Activity

            People

              amc Alan M. Carroll
              geek101 Powell Molleti
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: