[TS-290] Content-Type and Content-Language headers may be truncated in body factory responses

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.1
• Component/s: Core
• Assignee: Steve Jiang
• Reporter: Steve Jiang
• Created: 03/Apr/10 07:39
• Updated: 25/Aug/10 02:53
• Resolved: 29/May/10 08:24

Description

In HttpBodyFactory.cc: HttpBodyFactory::fabricate_with_old_api, there are a few ink_strncpys with sizeof(content_language_out) and sizeof(content_type_out). Those are declared as char array args, but sizeof returns the size of pointer. This truncates the strings to 4 or 8 bytes depending on platform.

HTTP/1.1 404 Not Found on Accelerator
Date: Sat, 03 Apr 2010 07:37:47 GMT
Connection: close
Server: ATS/2.1.0
Cache-Control: no-store
>>>> Content-Type: text/ht <<<<
Content-Language: en
Content-Length: 240