[TS-2867] traffic_shell uses predictable file names in public writable directories

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.2.2
• Assignee: Phil Sorber
• Reporter: Arno Toell
• Created: 02/Jun/14 08:35
• Updated: 15/Jul/14 20:05
• Resolved: 15/Jul/14 20:05

Description

Forwarded from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749846, thus quoting the reporter (removed ATS 3.0 arguments):

The binary `/usr/bin/traffic_shell` contains the following strings, which
should be sufficient to explain the issue:

/bin/sort /tmp/zonetab.tmp > /tmp/zonetab

I didn't look at the code in depth, but there are at least two
errors here:

• Predictable filenames, allowing file truncation/removal.

• Race-conditions accessing files.

The code in question comes from:

trafficserver-3.0.5/mgmt/tools/SysAPI.cc + ConfigAPI.cc

git head is not affected as traffic_shell was removed there, however older including 3.0, 4.0 and 4.2 branches are vulnerable to this. I suggest that you assign a CVE ID to track this issue and fix this issue in all supported branches.

Note, that 3.0 has more vulnerabilities if you decide to fix this issue in 3.0 as well.